Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-751: Upgrade to Orchard Core 1.8 #160

Merged
merged 46 commits into from
Feb 21, 2024
Merged

OSOE-751: Upgrade to Orchard Core 1.8 #160

merged 46 commits into from
Feb 21, 2024

Conversation

Psichorex
Copy link
Contributor

@Psichorex Psichorex commented Jan 18, 2024 •
edited by jira bot
Loading

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jan 18, 2024 •
edited
Loading

Walkthrough

This update focuses on modernizing the Lombiq Helpful Extensions project by upgrading to .NET 8.0, enhancing dependency injection across various components, adopting asynchronous operations, and improving resource management. It also includes updates to Orchard Core packages, introduces new dependencies, and enhances the UI and functionality across various extensions and services. The changes aim to optimize performance, maintainability, and user experience.

Changes

File Path Change Summary
...Tests.UI.csproj Updated target framework to .NET 8.0 and Lombiq.Tests.UI package version.
.../Controllers/* Refactored to accept dependencies via constructor parameters; updated Content-Disposition header logic.
.../Extensions/CodeGeneration/*, .../ContentSets/*, .../ShapeTracing/*, .../TargetBlank/*, .../Widgets/* Modified to accept dependencies via constructors; adopted asynchronous operations.
.../Extensions/ContentSets/Indexes/*, .../Migrations.cs, .../ContentTypes/*, .../SiteTexts/* Constructors accept dependencies; replaced Create with CreateAsync; use of async operations for database and content definitions.
.../Extensions/Emails/*, .../Flows/*, .../Security/* Constructors modified for direct dependency injection.
.../Extensions/OrchardRecipeMigration/*, .../ResourceManagement/* Significant refactoring for dependency injection; updated logic based on dependencies.
FeatureIds.cs, .../Views/* Added constants and updated view files for styling and consistency.
Lombiq.HelpfulExtensions.csproj Updated to target .NET 8.0, upgraded OrchardCore packages, and added new package references.
.github/workflows/publish-nuget.yml Workflow reference updated to use a specific branch/tag for publishing.

Related issues

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@Psichorex
Merge remote-tracking branch 'origin/dev' into issue/OSOE-751
f946d0c
@Psichorex
Merge remote-tracking branch 'origin/dev' into issue/OSOE-751
761ef56
@Psichorex
Revert "Addressing warnings."This reverts commit c7e6731.# Conflicts:…
edc7f6b 
…#	Lombiq.HelpfulExtensions/Controllers/OrchardRecipeMigrationAdminController.cs#	Lombiq.HelpfulExtensions/Extensions/ContentSets/Drivers/ContentSetPartDisplayDriver.cs#	Lombiq.HelpfulExtensions/Extensions/ContentSets/Workflows/Drivers/ContentSetCreatingEventDisplayDriver.cs#	Lombiq.HelpfulExtensions/Extensions/SiteTexts/Services/ContentLocalizationSiteTextService.cs#	Lombiq.HelpfulExtensions/Extensions/SiteTexts/SiteTextMigrations.cs#	Lombiq.HelpfulExtensions/Extensions/TargetBlank/Filters/TargetBlankFilter.cs#	Lombiq.HelpfulExtensions/Extensions/Widgets/Liquid/MenuWidgetLiquidFilter.cs#	Lombiq.HelpfulExtensions/Extensions/Widgets/Migrations.csRevert "Addressing warnings."This reverts commit a41d98e.# Conflicts:#	Lombiq.HelpfulExtensions/Extensions/ContentSets/Drivers/ContentSetContentPickerFieldDisplayDriver.cs#	Lombiq.HelpfulExtensions/Extensions/ContentSets/Workflows/Drivers/ContentSetGetSupportedOptionsEventDisplayDriver.cs#	Lombiq.HelpfulExtensions/Extensions/Security/Services/StrictSecurityPermissionAuthorizationHandler.cs#	Lombiq.HelpfulExtensions/Extensions/Workflows/Activities/GenerateResetPasswordTokenTask.cs

Revert "Addressing warnings."

This reverts commit 425acc0.

# Conflicts:
#	Lombiq.HelpfulExtensions/Extensions/Security/Services/StrictSecurityPermissionAuthorizationHandler.cs
@Piedone Piedone mentioned this pull request Feb 1, 2024
Merged
@Psichorex Psichorex merged commit 29c2ed1 into dev Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@Piedone Piedone Piedone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Psichorex @Piedone